Fix: useColors crash when themes remove the color pallete #18286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ellatrix,
talldan and
youknowriad
as code owners
epiqueras
reviewed
Nov 5, 2019
epiqueras
approved these changes
Nov 5, 2019
jorgefilipecosta
deleted the
fix/useColors-crashes-when-themes-remove-the-color-pallete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #18232
The useColors hook did not handle the case where themes disable color palette using:
This PR fixes the issue.
How has this been tested?
I added the following code to the functions.php file of the currently enabled theme (removing the code it contained setting a color palette):
I opened the editor, added a heading block, verified the block did not crash (on master it crashes), verified no preset colors were available.