-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: allow parent Block to consume child Block's toolbar #18440
Commits on Dec 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a83aef2 - Browse repository at this point
Copy the full SHA a83aef2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c54ebfe - Browse repository at this point
Copy the full SHA c54ebfeView commit details -
Update implementation to utilise InnerBlocks prop
Previously Block settings controlled whethere the toolbar was “consumed”. Now this is controlled by `InnerBlocks`.
Configuration menu - View commit details
-
Copy full SHA for e39d442 - Browse repository at this point
Copy the full SHA e39d442View commit details -
Configuration menu - View commit details
-
Copy full SHA for d90b837 - Browse repository at this point
Copy the full SHA d90b837View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5856315 - Browse repository at this point
Copy the full SHA 5856315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31b83f5 - Browse repository at this point
Copy the full SHA 31b83f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eaac1a - Browse repository at this point
Copy the full SHA 8eaac1aView commit details -
A parent of X denotes a the immediate progenitor of X. Using `hasSelectedInnerBlock` with the `deep` argument checks all levels of nesting of InnerBlocks. Therefore the value could be the parent but it could also be a grand-parent (and so on). As a result a more useful term is “ancestor”.
Configuration menu - View commit details
-
Copy full SHA for 2db6d67 - Browse repository at this point
Copy the full SHA 2db6d67View commit details -
Update to only show toolbar on immediate parent
This was happening anyway because Slots can only be rendered once. But this code makes it clearer as to the intent.
Configuration menu - View commit details
-
Copy full SHA for 49ef1c0 - Browse repository at this point
Copy the full SHA 49ef1c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e122c29 - Browse repository at this point
Copy the full SHA e122c29View commit details -
Update prop to better reflect usage
We’re not consuming toolbars as Block. We’re telling InnerBlocks to capture. The parent Block itself has no setting to denote that it is consuming toolbars.
Configuration menu - View commit details
-
Copy full SHA for 3db6d1b - Browse repository at this point
Copy the full SHA 3db6d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for df6b399 - Browse repository at this point
Copy the full SHA df6b399View commit details -
Configuration menu - View commit details
-
Copy full SHA for b59e38a - Browse repository at this point
Copy the full SHA b59e38aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdf2e46 - Browse repository at this point
Copy the full SHA bdf2e46View commit details -
Configuration menu - View commit details
-
Copy full SHA for c15e91b - Browse repository at this point
Copy the full SHA c15e91bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 272cb5a - Browse repository at this point
Copy the full SHA 272cb5aView commit details -
Update to implement new dual API for capturing
There are now two props available which handle capturing differently. See #18440 (comment)
Configuration menu - View commit details
-
Copy full SHA for 1a65b6a - Browse repository at this point
Copy the full SHA 1a65b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0ad245 - Browse repository at this point
Copy the full SHA b0ad245View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff8d134 - Browse repository at this point
Copy the full SHA ff8d134View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d6d089 - Browse repository at this point
Copy the full SHA 6d6d089View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6054b72 - Browse repository at this point
Copy the full SHA 6054b72View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a1d6d - Browse repository at this point
Copy the full SHA e3a1d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 368de62 - Browse repository at this point
Copy the full SHA 368de62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9917f68 - Browse repository at this point
Copy the full SHA 9917f68View commit details -
Revert "Display current Block name within “captured” child Block tool…
…bars" This reverts commit f40e8f2bf57eb1e4ce20013b688e28a109021e6d. Removing because it muddies the PR and starts to address more complex UI issues. Limiting the PR scope by reverting this.
Configuration menu - View commit details
-
Copy full SHA for e68af80 - Browse repository at this point
Copy the full SHA e68af80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e9eafd - Browse repository at this point
Copy the full SHA 8e9eafdView commit details -
Fix issue with forcing toolbars and refs due to rendering x2 toolbars
Previously we were rendering x2 toolbars which cause the ref associated with forcing toolbars to become out of sync. This meant that using keyboard shortcuts to focus the toolbar didn’t work. Fixed by rendering component on demand.
Configuration menu - View commit details
-
Copy full SHA for a1689e6 - Browse repository at this point
Copy the full SHA a1689e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20496fb - Browse repository at this point
Copy the full SHA 20496fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a5a1bb - Browse repository at this point
Copy the full SHA 4a5a1bbView commit details -
Removes capturing toolbars on Nav Block
As the API is experimental, remove it from any public Blocks for now.
Configuration menu - View commit details
-
Copy full SHA for 0b49632 - Browse repository at this point
Copy the full SHA 0b49632View commit details -
Configuration menu - View commit details
-
Copy full SHA for f40c2f1 - Browse repository at this point
Copy the full SHA f40c2f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6241c7 - Browse repository at this point
Copy the full SHA a6241c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 617fe50 - Browse repository at this point
Copy the full SHA 617fe50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b9b75f - Browse repository at this point
Copy the full SHA 1b9b75fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f90c6f - Browse repository at this point
Copy the full SHA 1f90c6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 841b4a8 - Browse repository at this point
Copy the full SHA 841b4a8View commit details