Remove CollegeHumor from embed providers

[audrasjb]

CollegeHumor doesn't support oEmbed anymore, so this PR removes the related blocks.

For reference, see the related Trac ticket: https://core.trac.wordpress.org/ticket/48696
Fixes #18567

Cheers,
Jb

[gziolo]

Thanks @audrasjb for starting this PR. I'm afraid we can't simply remove this embed because this will create backward compatibility issues for posts created in the past. Users would see the message like:
Your site doesn’t include support for the "core-embed/collegehumor" block...

There is some prior art though where @ice9js added a deprecation logic for the Crowdsignal embed. See #12854. I think it can be replicated here, the difference is that we don't need to add a new embed but probably change the pattern for the YouTube embed.

[audrasjb]

Thanks for the review @gziolo !
I updated the patch accordingly :)

[mcsf]

I'm afraid we can't simply remove this embed because this will create backward compatibility issues for posts created in the past. […]

There is some prior art though […]

I came here because of the same thing. This is definitely something we need to fix in the embed blocks framework. Embed blocks probably just need to be multiple expressions of a single block type, so that we don't need to maintain these things ad hoc.

[audrasjb]

Ok! Thanks @gziolo, makes sense.
I updated the patch accordingly.

[gziolo]

I googled to find some old url, example:
http://www.collegehumor.com/video/60123495/real-adults-dont-order-dessert

When I embed it, it get recognized as a general embed when I paste it. Is that okay?

[audrasjb]

@gziolo Looks good to me.
FYI, non embed will be generated at all outside the block editor.
https://core.trac.wordpress.org/attachment/ticket/48696/Capture%20d%E2%80%99%C3%A9cran%202019-11-18%20%C3%A0%2020.47.52.png

[gziolo]

We will have to re-test it once the core patch lands.

Let's move forward as is. I applied the label Needs Dev Note to ensure we revisit it later. I assume we will need a note for WordPress 5.4 release for the core part anyway.

[gziolo]

One more thing to unblock merging, https://travis-ci.com/WordPress/gutenberg/jobs/258989943#L608:

 /home/travis/build/WordPress/gutenberg/packages/block-library/src/embed/core-embeds.js
609[0]   148:5  error  Missing trailing comma  comma-dangle
610[0] 
611[0] ✖ 1 problem (1 error, 0 warnings)
612[0]   1 error and 0 warnings potentially fixable with the `--fix` option.

npm run lint-js:fix should be all that is necessary.

[mcsf]

Following up on #18591 (comment), although this doesn't address the issue of a single block type expressed as many blocks, it does "work" as a quick quick concept of handling missing embeds:

diff --git a/packages/blocks/src/api/parser.js b/packages/blocks/src/api/parser.js
index 6300eac32..4182375a9 100644
--- a/packages/blocks/src/api/parser.js
+++ b/packages/blocks/src/api/parser.js
@@ -455,9 +455,17 @@ export function createBlockWithFallback( blockNode ) {
 			innerHTML = originalContent;
 		}
 
-		name = unregisteredFallbackBlock;
-		attributes = { originalName, originalContent, originalUndelimitedContent };
-		blockType = getBlockType( name );
+		// If detected as an embed whose definition is missing, automatically
+		// convert to generic embed.
+		if ( name.indexOf( 'core-embed/' ) === 0 ) {
+			name = 'core/embed';
+			blockType = getBlockType( name );
+			innerHTML = originalUndelimitedContent;
+		} else {
+			name = unregisteredFallbackBlock;
+			attributes = { originalName, originalContent, originalUndelimitedContent };
+			blockType = getBlockType( name );
+		}
 	}
 
 	// Coerce inner blocks from parsed form to canonical form.

[gziolo]

@mcsf - did you just propose a way to deprecate all individual embeds and integrate them as one block type with different providers defined as patterns? 😃

[mcsf]

😆

[audrasjb]

@gziolo I tried npm run lint-js:fix but merging is still blocked, sorry 😬

[mcsf]

There seem to be some intermittent test failures. Re-running failed tests.

[gziolo]

There are some unrelated changes included in this file. I bet they should be removed from this patch.

[audrasjb]

This is the result of npm run lint-js:fix command on my branch. Should I remove them with a new commit?

[gziolo]

It's rather from npm install :)
Yes, please remove it.

[audrasjb]

Thanks @gziolo, we should be good to go now :)

[gziolo]

Thanks @audrasjb for this patch 👍

[audrasjb]

For your information, the related Core ticket has been committed and reopened for 5.3.1 consideration.
https://core.trac.wordpress.org/ticket/48696