Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Fix issue creating front-end markup #18607

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Navigation: Fix issue creating front-end markup #18607

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5562d1
navigation: esc attrs making markup
retrofox Nov 19, 2019
739d3bd
navigation: use esc_url() for href atter
retrofox Nov 19, 2019
760f0a5
navigation: use esc_html() for html code
retrofox Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/block-library/src/navigation/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ function build_navigation_html( $block, $colors ) {

// Start appending HTML attributes to anchor tag.
if ( isset( $block['attrs']['url'] ) ) {
$html .= ' href="' . $block['attrs']['url'] . '"';
$html .= ' href="' . esc_url( $block['attrs']['url'] ) . '"';
}
if ( isset( $block['attrs']['title'] ) ) {
$html .= ' title="' . $block['attrs']['title'] . '"';
$html .= ' title="' . esc_attr( $block['attrs']['title'] ) . '"';
}

if ( isset( $block['attrs']['opensInNewTab'] ) && true === $block['attrs']['opensInNewTab'] ) {
Expand All @@ -103,7 +103,7 @@ function build_navigation_html( $block, $colors ) {
// Start anchor tag content.
$html .= '>';
if ( isset( $block['attrs']['label'] ) ) {
$html .= $block['attrs']['label'];
$html .= esc_html( $block['attrs']['label'] );
}
$html .= '</a>';
// End anchor tag content.
Expand Down