Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeControl: Fix initialPosition to accept 0 #18611

Merged
merged 2 commits into from
Dec 17, 2019
Merged

RangeControl: Fix initialPosition to accept 0 #18611

merged 2 commits into from
Dec 17, 2019

Commits on Nov 19, 2019

  1. RangeControl: Fix initialPosition to accept 0 

    This update fixes the `initialPosition` prop for `RangeControl` to properly handle a value of `0`. Previously, the fallback value was checking for truthiness, which does not allow for `0` to work.

Being able to set the value to `0` is important with something like a range slider, as you may not have
an initial value, but you would like the slider to start from the very beginning (with an example range of 0-20).
    Jon Q committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    8208c56 View commit details
    Browse the repository at this point in the history

  2. Refactor initialPosition valoue check. Rename initialValue story

    Jon Q committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    8bceeaf View commit details
    Browse the repository at this point in the history