Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Fix multi-select inspector padding #18847

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@aduth
Copy link
Member

aduth commented Nov 30, 2019

Fixes #17975.
Possibly related: #17880 (cc @jorgefilipecosta ?)

This pull request seeks to resolve an issue where the block inspector does not have sufficient padding for multi-selections. It appears that the sidebar area previously had some default padding that was intended to be offset by the multi-inspector, and that this padding no longer exists. The inspector can simply apply its own padding.

These changes also use the variable $grid-size-large to align with that of the single block inspector card (see #17880). There should be no effective change, since $grid-size-large is the same 16px value.

Before After
Before After

Testing Instructions:

  1. Navigate to Posts > Add New
  2. Insert multiple blocks
  3. Select multiple blocks
  4. Verify padding displays as expected in sidebar inspector title
@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor

ZebulanStanphill commented Nov 30, 2019

Fixes #17975.

@aduth aduth merged commit 63f0a5b into master Dec 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the fix/multi-select-inspector-padding branch Dec 2, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.