Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove block hover border accidentally reintroduced by #18867. #18921

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Remove block hover border accidentally reintroduced by #18867. #18921

merged 1 commit into from
Dec 4, 2019

Conversation

ZebulanStanphill
Copy link
Member

Description

#18862 removed the block hover styles, but then #18867 accidentally brought part of those styles back. This PR re-removes those styles.

Screenshots

Before:
image

After:
image

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ZebulanStanphill ZebulanStanphill added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Dec 4, 2019
@ZebulanStanphill ZebulanStanphill mentioned this pull request Dec 4, 2019
Merged
@ZebulanStanphill ZebulanStanphill merged commit dbaa29a into master Dec 4, 2019
@ZebulanStanphill ZebulanStanphill deleted the remove/block-hover-left-border branch December 4, 2019 23:29
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ZebulanStanphill @ellatrix @youknowriad