Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi select: set focus back after attempt #19720

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Multi select: set focus back after attempt #19720

merged 2 commits into from
Jan 17, 2020

Conversation

ellatrix
Copy link
Member

Description

Fixes #19702.

After attempting to multi select (without making a multi selection), focus should be restored to the anchor element.

How has this been tested?

See #19702.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Feature] Block Multi Selection The ability to select and manipulate multiple blocks labels Jan 17, 2020
@ellatrix
Copy link
Member Author

Added an e2e test and verified that it fails in master.

@ellatrix
Copy link
Member Author

This feels solid to me. We already have a few multi-select by mouse e2e tests so I'm pretty confident in this change.

@ellatrix ellatrix merged commit c8a1eef into master Jan 17, 2020
@ellatrix ellatrix deleted the fix/focus-after-multi-select branch January 17, 2020 16:21
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
This was referenced Jan 21, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees
No one assigned
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.

Paragraph block: Selecting text from end to beginning will also select the block
1 participant
@ellatrix