Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format-js to scripts README for Prettier support #19766

Closed
wants to merge 4 commits into from
Closed

Add format-js to scripts README for Prettier support #19766

wants to merge 4 commits into from

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jan 20, 2020

Description

Updates the scripts README with format-js instructions for Prettier support.
This should either be cherry picked into #18048 or merged after.

Types of changes

Documentation, confirm it works as expected.

@mkaz mkaz added [Type] Developer Documentation Documentation for developers [Package] Scripts /packages/scripts labels Jan 20, 2020
@mkaz mkaz mentioned this pull request Jan 20, 2020
Merged
gziolo
gziolo approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @mkaz. I’d appreciate sanity check from @jsnajdr.

ntwb
ntwb reviewed Jan 20, 2020
View reviewed changes
packages/scripts/README.md Outdated Show resolved Hide resolved
ntwb
ntwb requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to update the instances of format-js to format:js in line with the lint:* nomenclature.

There are already a couple of instances where format:js was used to

@mkaz @ntwb
Update packages/scripts/README.md
808642d 
Co-Authored-By: Stephen Edgar <stephen@netweb.com.au>
ntwb
ntwb reviewed Jan 21, 2020
View reviewed changes
packages/scripts/README.md Outdated Show resolved Hide resolved
ntwb
ntwb approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@mkaz
Copy link
Member Author

mkaz commented Jan 29, 2020

Closing in favor of #19946

@mkaz mkaz closed this Jan 29, 2020
@mkaz mkaz deleted the docs/scripts-prettier branch January 29, 2020 14:19
@gziolo
Copy link
Member

gziolo commented Jan 29, 2020

I see I reviewed it and missed when working on my patch 😞

The good part is that the version I pushed looks similar :)

@gziolo gziolo mentioned this pull request Jan 29, 2020
Merged
1 task
@mkaz
Copy link
Member Author

mkaz commented Jan 29, 2020

I've done similar, so no worries. There's so much happening hard to keep track of every PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ntwb ntwb ntwb approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkaz @gziolo @ntwb