Social Link: Fix server-side rendering for legacy format #20074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in #19887. While changing the logic in `register_block_core_social_link` to consume the block type's `block.json` and switch to the `$service` attribute name, I broke the handling of the legacy format for social links. Old format: <!-- wp:social-link-wordpress {"url":"foo"} /--> New format: <!-- wp:social-link {"service":"wordpress","url":"foo"} /--> This fixes the handling of legacy social links by providing the adequate attribute default for each `$service`.
mcsf
added
[Type] Bug
gziolo
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #19887.
While changing the logic in
register_block_core_social_linkto consume the block type'sblock.jsonand switch to the$serviceattribute name, I broke the handling of the legacy format for social links.Old format:
<!-- wp:social-link-wordpress {"url":"foo"} /-->New format:
<!-- wp:social-link {"service":"wordpress","url":"foo"} /-->This fixes the handling of legacy social links by providing the adequate attribute default for each
$service.How has this been tested?
Make sure both new and old formats of social links are correctly rendered in the front-end.
Screenshots
Types of changes
Bug fix
Checklist: