Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navigation button expand to fit longer nav link text #20230

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

glendaviesnz
Copy link
Contributor

@glendaviesnz glendaviesnz commented Feb 14, 2020

Description

Fixes #20156 by making button grow to fit long navigation link text.

How has this been tested?

Tested manually by adding long navigation labels to navigation block links

Screenshots

Before:
Screen Shot 2020-02-14 at 4 10 34 PM

After:
Screen Shot 2020-02-14 at 4 11 09 PM

Types of changes

minor css change

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@glendaviesnz glendaviesnz added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Feb 14, 2020
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and fixes the issue. LGTM

@draganescu draganescu merged commit 7924f06 into master Feb 14, 2020
@draganescu draganescu deleted the fix/navigation-block-button-text branch February 14, 2020 09:15
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Navigation: Long block labels wrap breaking the layout
2 participants