Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the editor fullscreen by default #20611

Merged
merged 2 commits into from Mar 3, 2020

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Mar 3, 2020

We had a lot of feedback suggesting that the Fullscreen mode is a better experience and that it should be enabled by default.

Let's explore this in the plugin for a few releases. Thoughts?

@shaunandrews

This comment has been minimized.

Copy link
Contributor

shaunandrews commented Mar 3, 2020

When I use the editor in its normal mode (not full-screen) I've essentially trained my eyes to ignore the wp-admin toolbar and sidebar. Removing these elements by default seems like a good move to me — especially so if we consider adding better ways to toggle the wp-admin elements.

@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Mar 3, 2020

Yep, agreed. This change helps bring people into the editor without keeping all the other visual distractions. It provides so much more focus!

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Mar 3, 2020

Size Change: +6 B (0%)

Total Size: 865 kB

Filename Size Change
build/edit-post/index.js 90.9 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 105 kB 0 B
build/block-editor/style-rtl.css 10.5 kB 0 B
build/block-editor/style.css 10.5 kB 0 B
build/block-library/editor-rtl.css 7.36 kB 0 B
build/block-library/editor.css 7.36 kB 0 B
build/block-library/index.js 116 kB 0 B
build/block-library/style-rtl.css 7.5 kB 0 B
build/block-library/style.css 7.51 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.6 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.6 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/style-rtl.css 8.53 kB 0 B
build/edit-post/style.css 8.53 kB 0 B
build/edit-site/index.js 4.63 kB 0 B
build/edit-site/style-rtl.css 2.51 kB 0 B
build/edit-site/style.css 2.51 kB 0 B
build/edit-widgets/index.js 4.42 kB 0 B
build/edit-widgets/style-rtl.css 2.59 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 325 B 0 B
build/editor/editor-styles.css 327 B 0 B
build/editor/index.js 44.6 kB 0 B
build/editor/style-rtl.css 3.98 kB 0 B
build/editor/style.css 3.98 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.6 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.48 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.02 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Mar 3, 2020

The other efforts in #20603 help provide a nice connection between the two interfaces, helping enable this change.

Outside of the space/focus related benefits this brings, there are some benefits to scrolling as well, especially visible on small screens, 13'' or smaller.

@youknowriad youknowriad requested review from ajitbohra, gziolo, nerrad and ntwb as code owners Mar 3, 2020
@SchneiderSam

This comment has been minimized.

Copy link

SchneiderSam commented Mar 3, 2020

More focus is fine, but somehow it was also great that you can quickly click through the admin menu. Directly from the editor. Wouldn't you have to rework the whole admin menu in this context? And above all please simplify :-)

Copy link
Member

jorgefilipecosta left a comment

The PR looks good to me, and I verified if I clear local storage with window.localStorage.clear(); when I load the editor it loads in full screen.

@mapk
mapk approved these changes Mar 3, 2020
Copy link
Contributor

mapk left a comment

Yep. LGTM! :shipit:

@youknowriad youknowriad merged commit 1671a97 into master Mar 3, 2020
3 checks passed
3 checks passed
build
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the update/make-editor-fullscreen-by-default branch Mar 3, 2020
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Mar 3, 2020
jorgefilipecosta added a commit that referenced this pull request Mar 3, 2020
jorgefilipecosta added a commit that referenced this pull request Mar 3, 2020
@jorgefilipecosta jorgefilipecosta mentioned this pull request Mar 3, 2020
nylen pushed a commit to nylen/wordpress-develop-svn that referenced this pull request Mar 3, 2020
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.

git-svn-id: https://develop.svn.wordpress.org/trunk@47421 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Mar 3, 2020
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.

git-svn-id: https://develop.svn.wordpress.org/trunk@47421 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 3, 2020
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.
Built from https://develop.svn.wordpress.org/trunk@47421


git-svn-id: http://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Mar 3, 2020
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.
Built from https://develop.svn.wordpress.org/trunk@47421


git-svn-id: https://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@kadamwhite

This comment has been minimized.

Copy link
Contributor

kadamwhite commented Mar 3, 2020

I'm not opposed to the change but this is extremely last-minute, and making a fairly substantive change to the editor's behavior hours before RC does not make much sense to me. Why couldn't this have waited for 5.5?

@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Mar 4, 2020

Granted it's a bit late in the cycle but this change has been considered a quick win by release leads and not impactful as recent user tests have shown that it leads to better User experience.

There's still the possibility to revert it if there's anything wrong about it.

@jdevalk

This comment has been minimized.

Copy link
Contributor

jdevalk commented Mar 4, 2020

I am VERY opposed to this change and am deeply saddened by this happening so late in a release. One hour before RC1 you commit something that changes the way people's edit screen looks, and thus force loads of people to update training materials etc. I think this should be reconsidered for a next release and then properly discussed, and reverted as soon as possible now.

@afercia

This comment has been minimized.

Copy link
Contributor

afercia commented Mar 4, 2020

We had a lot of feedback suggesting that the Fullscreen mode is a better experience

recent user tests have shown that it leads to better User experience

Would you be so kind to make these data public? Specifically:

  • where and when the feedback was collected and where other contributors can examine it
  • where and when specific user tests on fullscreen mode ran and where the collected data can be consulted now

Making these data public would greatly help other contributors to make well informed judgments on this change. Thank you.

@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Mar 4, 2020

Additional context for why to include this, even if late in the process, is being discussed in https://make.wordpress.org/core/2020/03/03/fullscreen-mode-enabled-by-default-in-the-editor/
Let’s continue the discussion there, to increase visibility and not fragment the conversation.

@jdevalk

This comment has been minimized.

Copy link
Contributor

jdevalk commented Mar 4, 2020

Commented there, thanks for the note @youknowriad

@paaljoachim

This comment has been minimized.

Copy link

paaljoachim commented Mar 9, 2020

It is too late to add this feature during a RC, and it should be punted to WordPress 5.5.
No one should be able to trumph through a feature at this time. The higher ups in this hierarchy should show respect for the WordPress release process.
@m

@jorgefilipecosta

This comment has been minimized.

Copy link
Member

jorgefilipecosta commented Mar 10, 2020

Hi @paaljoachim,

It is too late to add this feature during a RC, and it should be punted to WordPress 5.5.

This PR is not adding the feature. The feature already existed; this PR is just enabling it by default for users that don't have a preference for fullscreen currently set on their local storage.
This change was included before the first RC was released, so the feature was added during the beta period.

@paaljoachim

This comment has been minimized.

Copy link

paaljoachim commented Mar 10, 2020

Hi Jorge. @jorgefilipecosta

Thank you for the response!

I phrased it in the wrong way. I should instead have said adding a visual UI change this late should not be allowed, but rather given more time to do research on how this will affect new users. Anyhow it needs a good discussion and hopefully that will be done during Wednesdays Dev Slack chat.

@feastdesignco

This comment has been minimized.

Copy link

feastdesignco commented Mar 11, 2020

Cross-posting:

Results are in, and they're not even close.
image

Of 244, 85 don't use the block editor yet. Anecdotally, this is because they're afraid that converting their content is going to break it. This is because there’s a lack of good tutorials, and news that the kinds of unprofessional shenanigans going on like this thread.

This leaves 159 people using the block editor

If we're generous and lump the last 2 groups together, 11 of 159 people support the idea of defaulting to full screen without the sidebar and admin bar. That's 7%.

That leaves 93% of people using the block editor against this change.

This is the first and only public survey taken on this so far from PEOPLE WHO ACTUALLY USE THIS PRODUCT, not some unsubstantiated "uh we thought it was a good idea internally".

On average, I’d say that these respondents public 1-2 times per week, spending 3-4 hours per post.

Please listen to your users.

@jdevalk

This comment has been minimized.

Copy link
Contributor

jdevalk commented Mar 11, 2020

@feastdesignco it would help if you showed the source of this little piece of research? I assume you didn't do it in the "I hate the block editor group" but where you did it does kind of matter :P

@feastdesignco

This comment has been minimized.

Copy link

feastdesignco commented Mar 11, 2020

@feastdesignco it would help if you showed the source of this little piece of research? I assume you didn't do it in the "I hate the block editor group" but where you did it does kind of matter :P

@jdevalk I removed personally identifiable information from the responses for privacy reasons, but I'd be happy to share the source privately for verification with @youknowriad and the reviewers involved here.

Email skylar@ our domain dot com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.