Block library: Use block.json consistently for FSE blocks #20717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
gziolo
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/refactor-block-json-blocks
branch
from
72b893e
to
eb177c1
Compare
gziolo
force-pushed
the
update/refactor-block-json-blocks
branch
from
eb177c1
to
d21cc57
Compare
|
I see failures on Travis:
It looks like an issue with |
4 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #19786
This pull request seeks to update block registration for a number of full-site editing blocks to match that of other server-registered blocks leveraging
block.json. As noted in #19786, when a block registers settings both in PHP and viablock.json, it should be implemented as a merge of the PHP implementation of the JSON metadata. This also has the benefit of eliminating some duplication that currently exists between PHP implementation andblock.json("Post Date" and "Post Excerpt" block attributes definition). An exception was made for "Post Comments Count" blockclassNameattribute, which is registered only in PHP, as it's expected this would eventually be handled as part of the implementation of block "supports" server-side (e.g. #18414, specifically c7cded6).Testing Instructions:
There should be no regressions in the display or behavior of full-site editing blocks.
Check the source and ensure that
wp.blocks.unstable__bootstrapServerSideBlockDefinitionscall properly propagates all updated blocks and their definitions.