Update social links block to output a custom class on each individual link #20998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Mar 20, 2020
| @@ -19,14 +19,15 @@ function render_block_core_social_link( $attributes ) { | |||
| $attributes['label'] : | |||
| /* translators: %s: Social Link service name */ | |||
| sprintf( __( 'Link to %s' ), block_core_social_link_get_name( $service ) ); | |||
| $class_name = ( isset( $attributes['className'] ) ) ? ' ' . $attributes['className'] : false; | |||
There was a problem hiding this comment.
It seems we can remove the external parentheses ( isset( $attributes['className'] ) ) right?
There was a problem hiding this comment.
Yeah no problem, that was just how the rest of the ternary assignments were written for the other attributes in the function so I thought it might be a WordPress coding convention, I can update
There was a problem hiding this comment.
It's been updated to remove the external parentheses
There was a problem hiding this comment.
Sorry did not notice the other attributes also had parentheses, anyway I think they are not required so thank you for the update 👍
…n the individual social link items
brentswisher
force-pushed
the
update/social-link-custom-class
branch
from
8754ef3
to
811c6e3
Compare
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 23, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 23, 2020
jorgefilipecosta
removed
the
Backport to WP Beta/RC
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #19335 by updating
render_block_core_social_link()to append a custom class to each<li>if one is present.How has this been tested?
<li>has your custom class appended.Screenshots
Add a custom class 'CUSTOM' to the individual link
Add a custom class 'Banana' to the entire block
See that they both render correctly on the public side
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: