Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick PR's for WordPress 5.4 RC 4 #21083

Merged
merged 7 commits into from
Mar 23, 2020
Merged

Cherry Pick PR's for WordPress 5.4 RC 4 #21083

merged 7 commits into from
Mar 23, 2020

Conversation

jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Mar 23, 2020 •
edited
Loading

Description

This PR cherry picks the following PR's into wp/trunk:

PR titleAuthorChange required for cherry-picking
IE11: fix focus on backspace@ellatrix-
Data: Migrate post editor persistence with fullscreenMode false@aduth-
Update social links block to output a custom class on each individual link@brentswisher-
Edit Post: Make sidebar header focusable for button focus normalization@aduthUpdated end to end test snapshots. (in trunk no snapshot changes are required)
[ Latest Posts ] Fix link for read more markup@draganescu-
Fix input rules@ellatrix-
GradientPicker: Fix control point UI and drag interaction@ItsJonQ$button-size-small to $icon-button-size-small (the first var is not available on trunk)

These PR's will be part of WordPress 5.4 RC 4.

Besides this PR's, PR #21027 that was targeted to trunk is also part of RC 4. The PR fixes a regression present on the trunk but not preset on Gutenberg master.

How has this been tested?

I did some smoke tests and verified the branch, in fact, contained the expected fixes.

@ItsJonQ ItsJonQ self-requested a review March 23, 2020 15:18
ItsJonQ
ItsJonQ approved these changes Mar 23, 2020
View reviewed changes
Copy link

@ItsJonQ ItsJonQ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgefilipecosta It's a 🚀 from me! Tested the updates locally on Chrome and Firefox:

  • Data: Migrate post editor persistence with fullscreenMode false
  • Update social links block to output a custom class on each individual link
  • Edit Post: Make sidebar header focusable for button focus normalization
  • [ Latest Posts ] Fix link for read more markup
  • Fix input rules
  • GradientPicker: Fix control point UI and drag interaction

@ItsJonQ
Copy link

ItsJonQ commented Mar 23, 2020

@jorgefilipecosta I just tested @aduth 's update for:

Data: Migrate post editor persistence with fullscreenMode false

It looks like it's working as expected. I swapped between Classic and Gutenberg, along with using localStorage.clear() for testing.

@jorgefilipecosta jorgefilipecosta merged commit 50339a3 into wp/trunk Mar 23, 2020
@jorgefilipecosta jorgefilipecosta deleted the wp/trunk-5-4-0-rc-4 branch March 23, 2020 22:51
@jorgefilipecosta jorgefilipecosta mentioned this pull request Mar 23, 2020
Closed
nylen pushed a commit to nylen/wordpress-develop-svn that referenced this pull request Mar 23, 2020
@jorgefilipecosta
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
d92714b 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.

git-svn-id: https://develop.svn.wordpress.org/trunk@47495 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Mar 23, 2020
@jorgefilipecosta
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
def0da1 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.

git-svn-id: https://develop.svn.wordpress.org/trunk@47495 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 23, 2020
@jorgefilipecosta
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
61ddc8d 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.
Built from https://develop.svn.wordpress.org/trunk@47495


git-svn-id: http://core.svn.wordpress.org/trunk@47270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Mar 24, 2020
@jorgefilipecosta
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
18a900b 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.
Built from https://develop.svn.wordpress.org/trunk@47495


git-svn-id: https://core.svn.wordpress.org/trunk@47270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Mar 24, 2020
@youknowriad
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
b96fb9c 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth, jorgefilipecosta.
Merges [43274] to the 5.4 branch.
Fixes: #49688.


git-svn-id: https://develop.svn.wordpress.org/branches/5.4@47499 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 24, 2020
@youknowriad
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
2ca623e 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth, jorgefilipecosta.
Merges [43274] to the 5.4 branch.
Fixes: #49688.

Built from https://develop.svn.wordpress.org/branches/5.4@47499


git-svn-id: http://core.svn.wordpress.org/branches/5.4@47274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Mar 24, 2020
@youknowriad
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
597cd48 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth, jorgefilipecosta.
Merges [43274] to the 5.4 branch.
Fixes: #49688.

Built from https://develop.svn.wordpress.org/branches/5.4@47499


git-svn-id: https://core.svn.wordpress.org/branches/5.4@47274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
243newtech pushed a commit to 243newtech/admin that referenced this pull request Apr 14, 2020
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
720eb1b 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.
Built from https://develop.svn.wordpress.org/trunk@47495
243newtech pushed a commit to 243newtech/admin that referenced this pull request Apr 14, 2020
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
04c1816 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth, jorgefilipecosta.
Merges [43274] to the 5.4 branch.
Fixes: #49688.

Built from https://develop.svn.wordpress.org/branches/5.4@47499
VenusPR added a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
@VenusPR
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
ad8bf40 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at WordPress/gutenberg#21083.

Props itsjonq, mcsf, aduth, jorgefilipecosta.
Merges [43274] to the 5.4 branch.
Fixes: #49688.

Built from https://develop.svn.wordpress.org/branches/5.4@47499


git-svn-id: http://core.svn.wordpress.org/branches/5.4@47274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcsf mcsf mcsf approved these changes

@ItsJonQ ItsJonQ ItsJonQ approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@ellatrix ellatrix Awaiting requested review from ellatrix

@etoledom etoledom Awaiting requested review from etoledom

@mkaz mkaz Awaiting requested review from mkaz

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jorgefilipecosta @ItsJonQ @mcsf @ellatrix @draganescu @aduth @brentswisher