Add save shortcut for navigation menu screen #21342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
draganescu,
adamziel,
noisysocks and
tellthemachines
youknowriad
approved these changes
Apr 2, 2020
youknowriad
reviewed
Apr 2, 2020
packages/edit-navigation/src/components/menu-editor/shortcuts.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Apr 2, 2020
| return null; | ||
| } | ||
|
|
||
| MenuEditorShortcuts.Register = RegisterMenuEditorShortcuts; |
There was a problem hiding this comment.
I know we used this pattern in the other packages too, but I wonder if a hook is better than a component for the registration :) (not specific to this PR though)
|
Size Change: +449 B (0%) Total Size: 884 kB
ℹ️ View Unchanged
|
draganescu
reviewed
Apr 2, 2020
|
I need to update the package-lock file by the looks of it. Will do that tomorrow and then merge. Thanks for the speedy reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #21338
Adds a save shortcut for the navigation menu screen.
It does this via a
MenuEditorShortcutscomponent that might be useful for registering any other shortcuts.How has this been tested?
Note - when saving there's no success/error notifications. I've created #21344 to track that.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: