Prevent typing on a Popover from closing the block toolbar #21421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -9 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
|
@youknowriad I wrote some code to add a TextControl to the URLPopoverAtLink component and have been experiencing the same issue. When I type anything into the TextControl, the toolbar closes immediately. I've installed this PR to see if that fixes the issue but it doesn't. Is this relevant here or should I create a new issue?
|
|
@arnaudbroes How did you "install" the PR? Can you send me a zip with your plugin to try? |
With "installing" I mean downloading this PR, installing the .zip as a plugin and then running Here's the script in a plugin - |
|
I believe this will also fix #14890. |
|
@arnaudbroes Indeed, your bug is different one and I believe is related to RichText stealing focus. This was fixed in Gutenberg since we're using a new Link control though. I'm not sure what part of that link control triggers the focus move to RichText though. |
|
Tested and confirmed this fixes #21402 👍 |
Closed
whyisjake
pushed a commit
that referenced
this pull request
Apr 22, 2020
whyisjake
pushed a commit
that referenced
this pull request
Apr 23, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14890
closes #21402
the isTyping flag should only be triggered when we type on the canvas. This can be achieved constantly by checking the DOM event (and not the React event bubbling)
Testing instructions