-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font size control for heading block #21431
Conversation
Size Change: +6 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
2f2a1a4
to
43e94ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small PR, big feature :P
43e94ca
to
c947ffa
Compare
The best ones! |
@nosolosw Is there a way to define different preset values for different blocks? For example, is it possible to have the preset size values of the Heading block different than the preset size values of the Paragraph block? Currently, the Large and Huge values for the Heading Block are smaller than their default one, which is surprising for the user. |
That's on the roadmap, but it's not yet implemented.
This is something that is theme-specific, so it depends on the font-sizes themes add + how they decide to style the heading elements that don't have any style assigned yet (the default). I've checked TwentyNineteen and TwentyTwenty and both seem to do what you report. Were those the themes you tested? If so, perhaps it's best to search and comment on their issue tracker (twenty-nineteen, twenty-twenty). I hope this is helpful! |
Depends on #21428 which should land first.
This PR adds support for font-sizes at the heading block by leveraging the font size support key recently landed at #21153
How to test