Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test: <a> tag "target" attribute. #22200

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix flaky test: <a> tag "target" attribute. #22200

merged 1 commit into from
May 8, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented May 8, 2020

Description

Fix a flaky test caused by a racing condition between asserting snapshot and Gutenberg's updating DOM.

This test became really less flaky since #17126. But it was still possible.

How has this been tested?

Manually running the tests.

Screenshots

N/A

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] My code has proper inline documentation.
  • [N/A] I've included developer documentation if appropriate.
  • [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

@sainthkh
Copy link
Contributor Author

sainthkh commented May 8, 2020

Interestingly, a PR that fixes a flaky test failed by a flaky test. That flaky test is fixed in #22202.

@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] E2E Tests /packages/e2e-tests labels May 8, 2020
gziolo
gziolo approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should improve the stability of this test suite.

@gziolo gziolo merged commit 578a33a into WordPress:master May 8, 2020
@github-actions github-actions bot added this to the Gutenberg 8.1 milestone May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 8.1
Development

Successfully merging this pull request may close these issues.

E2E Tests: Intermittent failure in Links tests
2 participants
@sainthkh @gziolo