Use alternate display for the popover in alignment matrix. #22351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: +10 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
chrisvanpatten
approved these changes
May 14, 2020
|
I think you might have unintentionally made all dropdowns use the alternate prop now. Before:
After:
I'll try to spin up a PR to fix this. |
|
I kind of like that 😅 |
|
:) I think there's always a place to look for reduction and removing elevation. But in this case, I feel like we haven't really given the current setup a shot yet — which is: popovers that are part of the dark-bordered block toolbar, are block toolbar material. Everything else is menus, and they have a shadow, and typically those gray separators which feel out of place in the above screenshot. A revisit is possible, but we should be intentional about it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the border to be consistent with the toolbar design: