Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-handle to all script tags in the admin. #22721

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Add data-handle to all script tags in the admin. #22721

merged 3 commits into from
Jun 4, 2020

Conversation

spacedmonkey
Copy link
Member

Description

Add all handle as attribute on all script tags.
Only do this in the admin and if block directory is enabled.

Related: #22703

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@spacedmonkey spacedmonkey requested a review from gziolo May 28, 2020 20:51
@github-actions
Copy link

github-actions bot commented May 28, 2020 •
edited
Loading

Size Change: -7.83 kB (0%)

Total Size: 1.12 MB

Filename Size Change
build/annotations/index.js 3.62 kB +3 B (0%)
build/block-directory/index.js 6.48 kB +1 B
build/block-directory/style-rtl.css 787 B -1 B
build/block-directory/style.css 787 B -1 B
build/block-editor/index.js 106 kB +97 B (0%)
build/block-editor/style-rtl.css 11.4 kB +344 B (3%)
build/block-editor/style.css 11.4 kB +346 B (3%)
build/block-library/editor-rtl.css 7.87 kB +665 B (8%) 🔍
build/block-library/editor.css 7.88 kB +667 B (8%) 🔍
build/block-library/index.js 126 kB +7.1 kB (5%) 🔍
build/block-library/style-rtl.css 7.69 kB +9 B (0%)
build/block-library/style.css 7.68 kB +5 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB -1 B
build/blocks/index.js 48.2 kB +38 B (0%)
build/components/index.js 190 kB +289 B (0%)
build/components/style-rtl.css 19.5 kB +2.39 kB (12%) ⚠️
build/components/style.css 19.5 kB +2.4 kB (12%) ⚠️
build/compose/index.js 9.32 kB +1 B
build/core-data/index.js 11.4 kB +2 B (0%)
build/data-controls/index.js 1.29 kB -3 B (0%)
build/data/index.js 8.43 kB +5 B (0%)
build/deprecated/index.js 772 B +1 B
build/edit-navigation/index.js 8.24 kB +1.62 kB (19%) ⚠️
build/edit-navigation/style-rtl.css 878 B +21 B (2%)
build/edit-navigation/style.css 876 B +20 B (2%)
build/edit-post/index.js 302 kB +15 B (0%)
build/edit-post/style-rtl.css 5.43 kB -6.79 kB (125%) 🏆
build/edit-post/style.css 5.43 kB -6.79 kB (125%) 🏆
build/edit-site/index.js 14.1 kB +34 B (0%)
build/edit-site/style-rtl.css 2.96 kB -2.57 kB (86%) 🏆
build/edit-site/style.css 2.96 kB -2.57 kB (86%) 🏆
build/edit-widgets/index.js 8.81 kB +759 B (8%) 🔍
build/edit-widgets/style-rtl.css 2.4 kB -2.19 kB (91%) 🏆
build/edit-widgets/style.css 2.4 kB -2.19 kB (90%) 🏆
build/editor/index.js 44.6 kB +12 B (0%)
build/editor/style-rtl.css 4.26 kB -793 B (18%) 👏
build/editor/style.css 4.27 kB -793 B (18%) 👏
build/element/index.js 4.64 kB -2 B (0%)
build/format-library/index.js 7.71 kB +3 B (0%)
build/hooks/index.js 2.13 kB +1 B
build/keyboard-shortcuts/index.js 2.51 kB +2 B (0%)
build/list-reusable-blocks/index.js 3.13 kB -2 B (0%)
build/media-utils/index.js 5.29 kB +1 B
build/notices/index.js 1.79 kB +1 B
build/nux/index.js 3.4 kB +1 B
build/plugins/index.js 2.56 kB -3 B (0%)
build/server-side-render/index.js 2.68 kB +1 B
build/viewport/index.js 1.84 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/date/index.js 5.47 kB 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@gziolo gziolo added the [Feature] Block Directory Related to the Block Directory, a repository of block plugins label May 29, 2020
@gziolo gziolo requested review from StevenDufresne, ryelle and TimothyBJacobs and removed request for ryelle, gziolo and TimothyBJacobs May 29, 2020 04:09
@gziolo gziolo added the [Type] Task Issues or PRs that have been broken down into an individual action to take label May 29, 2020
@spacedmonkey spacedmonkey requested a review from gziolo May 29, 2020 09:36
@TimothyBJacobs
Copy link
Member

This seems to make sense to me. I think we might want to esc_attr the handle to be safe against accidental quotes and the like.

spacedmonkey
spacedmonkey commented Jun 3, 2020
View reviewed changes
lib/block-directory.php Outdated Show resolved Hide resolved
@spacedmonkey
Copy link
Member Author

This seems to make sense to me. I think we might want to esc_attr the handle to be safe against accidental quotes and the like.

Thoughts @TimothyBJacobs on bad1dd4

@TimothyBJacobs
Copy link
Member

lgtm! There is an extra space around esc_attr.

@spacedmonkey
Copy link
Member Author

@TimothyBJacobs Fixed

@spacedmonkey spacedmonkey merged commit 15a8f21 into master Jun 4, 2020
@spacedmonkey spacedmonkey deleted the feature/data-handle branch June 4, 2020 09:07
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 4, 2020
@sarayourfriend sarayourfriend mentioned this pull request Jun 11, 2020
Closed
@Djennez Djennez mentioned this pull request Jun 15, 2020
Closed
@sarayourfriend sarayourfriend mentioned this pull request Jun 15, 2020
Open
3 tasks
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
Closed
12 tasks
dd32 added a commit to dd32/wordpress-develop that referenced this pull request Jun 26, 2020
@dd32
Add a unique data-handle property to enqueued <script> elements for i…
6f44b37 
…mproved debugging and future lazyloading. See WordPress/gutenberg#22721
@dd32 dd32 mentioned this pull request Jun 26, 2020
Open
@gziolo gziolo mentioned this pull request Dec 18, 2020
Closed
@ryelle ryelle mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

@StevenDufresne StevenDufresne Awaiting requested review from StevenDufresne

@ryelle ryelle Awaiting requested review from ryelle

Assignees
No one assigned
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 8.3
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @TimothyBJacobs @gziolo