-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classic block: Add height: auto to content wrapper #23547
Conversation
…mes to calculate height correctly
Size Change: +13 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
This tests well for me in Chrome, Firefox, Safari and Edge. |
👋 @talldan, @ntsekouras - we are trying to clear a few of the more annoying Classic block bugs ahead of the deprecation of the Calypso classic editor ... so if there was any chance of getting a sign off on this one in the next few days that would be much appreciated - many thanks 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glendaviesnz! It LGTM
awesome, thanks @ntsekouras and @mvdhoek1 |
Fixes: #10806
Description
Adds a height: auto setting to editor content wrapper others embed iframe heights are not calculated correctly in /wp-includes/js/mce-view.min.js
How has this been tested?
Just manually so far
Screenshots
Before:
After:
Types of changes
MInor css change
Checklist: