Components: Fix Toolbar arrow key navigation in RTL contexts #24043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
diegohaz
added
[a11y] Keyboard & Focus
[Package] Components
|
Size Change: +8 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jul 20, 2020
| @@ -12,12 +12,17 @@ import { forwardRef } from '@wordpress/element'; | |||
| * Internal dependencies | |||
| */ | |||
| import ToolbarContext from '../toolbar-context'; | |||
| import { getRTL } from '../utils/rtl'; | |||
There was a problem hiding this comment.
Ideally, we'd drop this in favor of { isRTL } from '@wordpress/i18n' but this could be separate as this is already used.
youknowriad
added
the
Backport to WP Beta/RC
6 tasks
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
youknowriad
removed
the
Backport to WP Beta/RC
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23265 (comment).
Before:
After:
How to test