Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport GB 8.6 fixes to WP trunk #24068

Merged
merged 23 commits into from Jul 20, 2020
Merged

Backport GB 8.6 fixes to WP trunk #24068

merged 23 commits into from Jul 20, 2020

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jul 20, 2020 •
edited

Description

Process:

Go to https://github.com/WordPress/gutenberg/pulls?q=is%3Apr+label%3A%22Backport+to+WP+Core%22+is%3Aclosed

Open the console.

let items = [];

For every page, run:

items = [ ...items, ...[ ...document.querySelectorAll( '.js-issue-row' ) ].map( ( element ) => ( { link: element.querySelector( 'a' ).href, dateTime: element.querySelector( 'relative-time' ).getAttribute( 'datetime' ) } ) ) ]

Finally, run:

items.sort( (a, b) => {
  if ( a.dateTime > b.dateTime ) {
    return 1;
  } else if ( a.dateTime < b.dateTime ) {
    return -1;
  }
  return 0;
} ).map( ( { link } ) => link ).join( '\n' )

Now I have the following list, from which I'm skipping pattern PRs.

#23855 skip
#23857 skip
#23853 skip
#23854 skip
#23858 skip
#23848 skip
#23916 ok
#23923 ok
#23930 ok
#23904 ok
#23610 ok
#23959 ok
#23964 ok
#23849 skip
#23948 ok
#23984 ok
#23980 ok
#23927 ok
#23950 ok
#23881 skip
#23966 ok
#24043 ok
#24041 ok
#23991 ok
#24047 ok
#23425 ok
#24022 ok
#24045 ok
#23936 ok
#20792 ok
#24059 ok

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

talldan and others added 4 commits July 20, 2020 20:22
@talldan @ellatrix
Fix drag and drop for aligned blocks (#23916)
1424ce0 
* Fix drag and drop for aligned blocks

* Update the mock class list implementation to be more flexible

* Fix test
@talldan @ellatrix
Fix drag and drop to empty block lists (#23923)
7e47aca
@youknowriad @ellatrix
Optimize selector calls (#23930)
6ff8d78
@ellatrix
Update Line-Height Settings for opt-in (rather than opt-out) (#23904)
caea9f1 
This update adjusts the line-height theme support setting to be opt-in via `add_theme_support( 'experimental-line-height' );` rather than enabled by default. This keeps it consistent with the other recently added style theme support settings like padding (spacing).
youknowriad and others added 14 commits July 20, 2020 20:38
@youknowriad @diegohaz @ellatrix
Use composite pattern to improve keyboard navigation on the inserter (#…
c11ace4 
…23610)

Co-authored-by: Haz <hazdiego@gmail.com>
@ntsekouras @ellatrix
persist tooltip on hover (#23959)
757ec73
@youknowriad @ellatrix
Make the line height and custom units theme support flags consistent (#…
b170159 
…23964)
@StevenDufresne @ellatrix
Remove messaging that suggests contacting administrator for users wit…
156e20a 
…hout permissions. (#23948)
@tacitonic @ellatrix
Remove core-embed/hulu (#23984)
e5400d9
@ZebulanStanphill @ellatrix
Fix block icon mouse out gesture issue. (#23980)
0777392
@ntsekouras @ellatrix
Fix edited Classic block's content deletion when switching to Code ed…
5cd6da2 
…itor (#23927)

* remove lodash debounce

* handle unmount with debounce for performance reasons

* add debounce time

* utilize lodash debounce cancel method
@talldan @ellatrix
Fix blocks dropping incorrectly in nested blocks (#23950)
1e82285
@mkaz @ellatrix
Image: Add the ability for a plugin to disable Image Editor (#23966)
60ae848
@diegohaz @ellatrix
Components: Fix Toolbar arrow key navigation in RTL contexts (#24043)
9e09f3c
@ellatrix
RichText: restore aria-multiline (#24041)
a98ed29
@ellatrix @youknowriad
Fix block wrapper selector (#23991)
3c2507a 
* Fix block wrapper selector

* Fix linting issue

Co-authored-by: Riad Benguella <benguella@gmail.com>
@youknowriad @ellatrix
Prevent JavaScript error when using arrow navigation in URLInput (#24047
39ebeb5 
)
@ellatrix
Editor: Fix block highlight rendering after block is moved (#23425)
66d1d2d 
* Editor: Fix block outline rendering after block is moved

* Fix rendering for tests. Reduce Timeout from 250 -> 200 to improve UX.

* Fix rAF call with toggling highlight

* Resolve the E2E test issue, which appears to be caused by a double-mounting Toolbar

* Use reducer

Co-authored-by: Ella van Durpe <ella@vandurpe.com>
@github-actions
Copy link

github-actions bot commented Jul 20, 2020 •
edited

Size Change: +8.79 kB (0%)

Total Size: 1.14 MB

Filename Size Change
build/annotations/index.js 3.67 kB -4 B (0%)
build/autop/index.js 2.82 kB -1 B
build/block-directory/index.js 7.63 kB -42 B (0%)
build/block-editor/index.js 119 kB +9.31 kB (7%) 🔍
build/block-editor/style-rtl.css 10.7 kB +7 B (0%)
build/block-editor/style.css 10.7 kB +9 B (0%)
build/block-library/index.js 130 kB -35 B (0%)
build/blocks/index.js 48.2 kB -1 B
build/components/index.js 198 kB -521 B (0%)
build/components/style-rtl.css 15.8 kB -9 B (0%)
build/components/style.css 15.8 kB -10 B (0%)
build/compose/index.js 9.69 kB +15 B (0%)
build/core-data/index.js 11.4 kB +10 B (0%)
build/data-controls/index.js 1.29 kB -2 B (0%)
build/data/index.js 8.45 kB +4 B (0%)
build/date/index.js 5.38 kB -3 B (0%)
build/edit-navigation/index.js 9.92 kB +2 B (0%)
build/edit-post/index.js 304 kB +26 B (0%)
build/edit-site/index.js 16.7 kB +6 B (0%)
build/edit-widgets/index.js 9.38 kB +34 B (0%)
build/editor/index.js 45 kB +9 B (0%)
build/element/index.js 4.65 kB -7 B (0%)
build/format-library/index.js 7.73 kB -1 B
build/hooks/index.js 2.13 kB -2 B (0%)
build/i18n/index.js 3.57 kB +2 B (0%)
build/keyboard-shortcuts/index.js 2.52 kB -1 B
build/keycodes/index.js 1.94 kB -1 B
build/list-reusable-blocks/index.js 3.13 kB +4 B (0%)
build/notices/index.js 1.79 kB -2 B (0%)
build/nux/index.js 3.4 kB -1 B
build/plugins/index.js 2.56 kB +3 B (0%)
build/primitives/index.js 1.4 kB -7 B (0%)
build/priority-queue/index.js 789 B +1 B
build/redux-routine/index.js 2.85 kB -4 B (0%)
build/rich-text/index.js 13.9 kB +4 B (0%)
build/server-side-render/index.js 2.71 kB +1 B
build/shortcode/index.js 1.7 kB +1 B
build/token-list/index.js 1.27 kB -1 B
build/wordcount/index.js 1.17 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-library/editor-rtl.css 7.57 kB 0 B
build/block-library/editor.css 7.57 kB 0 B
build/block-library/style-rtl.css 7.78 kB 0 B
build/block-library/style.css 7.79 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/style-rtl.css 5.59 kB 0 B
build/edit-post/style.css 5.58 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.78 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/html-entities/index.js 622 B 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B

compressed-size-action

@youknowriad youknowriad merged commit 4c39059 into wp/trunk Jul 20, 2020
@youknowriad youknowriad deleted the backport/8.6 branch July 20, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@ajlende ajlende Awaiting requested review from ajlende

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@etoledom etoledom Awaiting requested review from etoledom

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ellatrix @youknowriad @talldan @ntsekouras @StevenDufresne @tacitonic @ZebulanStanphill @mkaz @diegohaz @afercia