Add navigation back button as separate component #25520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatf
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
joshuatf
force-pushed
the
add/nav-back-button
branch
from
bc47327
to
5914fc0
Compare
Copons
reviewed
Sep 22, 2020
| import { MenuBackButtonUI } from '../styles/navigation-styles'; | ||
|
|
||
| export default function NavigationMenu( props ) { | ||
| const { backButtonLabel, className, href, onClick, parentMenu } = props; |
There was a problem hiding this comment.
Nitpick: since props is not used in the component, we could just destructure it in the function parameter.
export default function NavigationMenu( { backButtonLabel, className, href, onClick, parentMenu } ) {
Copons
approved these changes
Sep 22, 2020
joshuatf
force-pushed
the
add/nav-back-button
branch
from
5914fc0
to
5ea665b
Compare
|
Thanks for the review, @Copons! Applied your feedback and fixed up conflicts. |
ZebulanStanphill
added
[Feature] Navigation Component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates the back button to a separate component so we can reuse styling for back buttons outside the parent/child relationship of menus. Also sneaks in a small styling change to fix margin between menu and buttons.
Used for the "WordPress Dashboard" button in the WooCommerce menu.
How has this been tested?
Tested using storybook examples and in the wc nav repo.
Screenshots
Testing
npm run storybook:dev.