Limit block supports flag support to v2 #26106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Block API
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
force-pushed
the
limit/block-supports-api-v2
branch
from
caa84d3
to
cfd94b5
Compare
youknowriad
commented
Oct 14, 2020
lib/block-supports/index.php
Outdated
| @@ -37,7 +37,7 @@ function gutenberg_apply_block_supports( $block_content, $block ) { | |||
|
|
|||
| $block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block['blockName'] ); | |||
| // If no render_callback, assume styles have been previously handled. | |||
| if ( ! $block_type || ! $block_type->render_callback ) { | |||
| if ( ! $block_type || ! $block_type->apiVersion || ! $block_type->apiVersion < 2 || ! $block_type->render_callback ) { | |||
There was a problem hiding this comment.
The apiVersion comes from block.json and is camel case (to match js rules), how did we solve this kind of issues in previous block.json properties cc @gziolo @mcsf @jorgefilipecosta
There was a problem hiding this comment.
We map everywhere to meet PHP coding style guidelines. It should be api_version in the block type object instance. I'm not sure about other places though.
There was a problem hiding this comment.
So when we call register_block_type explicitly, we should pass api_version right?
There was a problem hiding this comment.
Correct, this is what regiser_block_type_from_metadata does for other settings:
There was a problem hiding this comment.
Ok so for now, I explicitly added api_version to the registration call. We should do a patch for Core to add the api_version to that array.
There was a problem hiding this comment.
I agree with translating to snake case in PHP and with subsequently patching register_block_type_from_metadata.
|
Size Change: +17 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
limit/block-supports-api-v2
branch
from
cfd94b5
to
25d6ad5
Compare
youknowriad
requested review from
ajitbohra,
mkaz,
Soean and
talldan
as code owners
11 tasks
youknowriad
commented
Oct 14, 2020
| @@ -522,6 +523,16 @@ class LatestPostsEdit extends Component { | |||
| } | |||
| } | |||
|
|
|||
| function LatestPostBlockWrapper( props ) { | |||
There was a problem hiding this comment.
Ideally, we refactor the whole block to be a functional component, but this is better done on a separate PR. This should be enough for the moment.
|
I think this one is not needed anymore since the API is explicit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid impacting existing dynamic blocks, this PRs only enable block supports server-side for blocks using apiVersion 2.