-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Tooling: Rebuild stylesheets when imported styles are modified #26649
Conversation
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me! Its actually updating the scss on save. 😄 🎉
3dc7944
to
126ca48
Compare
126ca48
to
0f63597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested following your testing steps. It's working perfectly! 👍 🥳 Code looks good to me!
0f63597
to
e713ca6
Compare
Description
The local dev environment wasn't reloading style updates properly when modifying stylesheets that were separate (but imported) by another package.
Ex. Updates to styles in the interface package were not being propagated to the site editor stylesheet (which imports interface package styles, and should, theoretically, update as well)
How has this been tested?
npx wp-env start
)npm run dev
packages/interface/src/components/interface-skeleton/style.scss:98
and change the background-color to something notable, like purplepackages/interface/build-style/style.css:317
andpackages/edit-site/build-style/style.css:317
. These are the transpiled stylesheets that should reflect up to date styling changes. Confirm that the background color has been updated to purple in both of these files.Types of changes
Bug fix for #26669
Checklist: