Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Font size picker does not correctly handles big font sizes. #26705

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Fix: Font size picker does not correctly handles big font sizes. #26705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/components/src/font-size-picker/index.js
View file
Open in desktop
Expand Up @@ -21,6 +21,7 @@ import VisuallyHidden from '../visually-hidden';

const DEFAULT_FONT_SIZE = 'default';
const CUSTOM_FONT_SIZE = 'custom';
const MAX_FONT_SIZE_DISPLAY = '25px';

function getSelectValueFromFontSize( fontSizes, value ) {
if ( value ) {
Expand All @@ -45,7 +46,9 @@ function getSelectOptions( optionsArray, disableCustomFontSizes ) {
key: option.slug,
name: option.name,
size: option.size,
style: { fontSize: option.size },
style: {
fontSize: `min( ${ option.size }, ${ MAX_FONT_SIZE_DISPLAY } )`,
},
} ) );
}

Expand Down