Remove unused redux-optimist dependency #27798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
|
Size Change: -724 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
The failing test was fixed in master by #27802 |
ntsekouras
reviewed
Dec 18, 2020
ntsekouras
reviewed
Dec 18, 2020
youknowriad
force-pushed
the
remove/redux-optimist
branch
from
c192c1e
to
8bab90c
Compare
ntsekouras
reviewed
Dec 18, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved from the "editor" store to "core" store (something like in WP 5.3 maybe), we stopped using
redux-optimistbut it was kept in several places of our code base. This PR removes this unused code and also deprecates the selectors/actions that are useless.