Use @wordpress/stylelint-config in @wordpress/scripts #27810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
|
@ocean90, I'll have a look at the issue you described Monday at the latest 👍🏻 |
ocean90
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
talldan
as code owners
|
@gziolo Sorry, read the docs again and I was missing the |
gziolo
reviewed
Dec 18, 2020
There was a problem hiding this comment.
Amazing work, thank you for wrangling it ❤️
I'm wondering if we want to batch more changes for the next major version of @wordpress/scripts. There is also PR (#26382) from @jsnajdr that upgrades webpack from v4 to v5 waiting to be merged.
There is also approved PR (#27327) from @sirreal that enabled new ESLint rules.
Some other items that we should consider:
- Update @wordpress/scripts to use PostCSS 8 Update @wordpress/scripts to use PostCSS 8 #27028
- Upgrade Jest to the new major version (26.x) Scripts: Upgrade Jest to the new major version (26.x) #22395
gziolo
added
[Type] New API
gziolo
approved these changes
Dec 18, 2020
|
I created a milestone to make it easier to track what could go in the next major release of The alternative approach is to merge breaking changes as they are ready (this is what we’ve been doing so far) and accept the fact that we have more often breaking changes. As far as I can tell, well-established projects (Jest, ESLint, Babel) try to minimize the number of major releases but we depend on them so it’s complicated 😃 |
gziolo
force-pushed
the
update/stylelint-config
branch
from
279d855
to
44f012c
Compare
|
I rebased this PR with the latest changes in the main branch. If CI checks pass it should be fine to merge it. I started merging a number of PRs that introduce breaking changes to |
|
There is one e2e test failing that can't be related to those changes because we introduce changes only for style linting 🤷🏻 Let's proceed. |
This was referenced Jan 3, 2021
This was referenced Mar 19, 2021
This was referenced Apr 6, 2021
This was referenced Apr 7, 2021
This was referenced Apr 7, 2021
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #22777.
Fixes #27775.
I have trouble with updating stylelint in the
package-lock.json. I tried the steps in https://github.com/WordPress/gutenberg/tree/master/packages#updating-existing-dependencies but it only updates the version.npm update stylelintdid nothing either. @gziolo Can you help?How has this been tested?
Screenshots
Types of changes
Checklist: