Tools: Update the minimum Node.js version to 12 #27934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
[Type] Breaking Change
gziolo
added
[Package] Library Export Default Webpack Plugin
[Package] Dependency Extraction Webpack Plugin
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
gziolo
changed the title
gziolo
force-pushed
the
update/node-12-tools
branch
from
47a4605
to
587c257
Compare
gziolo
added
npm Packages
gziolo
force-pushed
the
update/node-12-tools
branch
2 times, most recently
from
d180491
to
d868e91
Compare
gziolo
force-pushed
the
update/node-12-tools
branch
3 times, most recently
from
af236b5
to
0141aeb
Compare
gziolo
force-pushed
the
update/node-12-tools
branch
from
0141aeb
to
eba20b7
Compare
gziolo
force-pushed
the
update/node-12-tools
branch
from
eba20b7
to
ff5f90f
Compare
|
Let's give it a try. The failing e2e test is a known issue that pops up in the main branch as well. |
|
Just reviewing it now, was going to give it my 👍 and the option disappeared. |
This was referenced Jan 12, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting 2020-05-19 Node.js v10 is in maintenance mode. In fact, Node.js v12 is now also in maintenance mode since 2020-11-30. Node.js v14 is active LTS, see:
https://github.com/nodejs/Release
I propose we drop support for Node.js v10 and lower in all WordPress packages, given that the dependent packages slowly start to drop support as well.
Example:
webpack-bundle-analyzerstarting from v4 increased minimum Node.js version to 10.13 (https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md#400).wordpress-sourcesstarting from v2 increased minimum Node.js version to 10.13 (https://github.com/webpack/webpack-sources/releases/tag/v2.0.0).In practice, it’s more like a recommendation rather than a strict contract as npm will only warn when you install packages that defined
enginesinpackage.jsonthat aren’t satisfied by the current node or npm version declared.This PR sets the minimum Node.js version recommended to v12 in the following packages that are part of
@wordpress/scriptsfamily:@wordpress/babel-plugin-import-jsx-pragma@wordpress/babel-plugin-makepot@wordpress/babel-preset-default@wordpress/browserslist-config@wordpress/create-block@wordpress/custom-templated-path-webpack-plugin@wordpress/dependency-extraction-webpack-plugin@wordpress/e2e-test-utils@wordpress/e2e-tests@wordpress/eslint-plugin@wordpress/jest-console@wordpress/jest-preset-default@wordpress/jest-puppeteer-axe@wordpress/library-export-default-webpack-plugin@wordpress/npm-package-json-lint-config@wordpress/postcss-plugins-preset@wordpress/postcss-themes@wordpress/prettier-config@wordpress/scripts@wordpress/stylelint-configNote: For consistency all tooling related packages get a minimum Node.js version set even when some of them are simple enough to ignore that.
How has this been tested?
The following commands still work:
npm run buildnpm run devnpm run lint-jsnom run test-unit