Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stored values to be updated with new defaults #2809

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Allow stored values to be updated with new defaults #2809

merged 2 commits into from
Sep 28, 2017

Commits on Sep 27, 2017

  1. Allow stored values to be updated with new defaults 

    If we store preferences, then we want to add new preferences
with new defaults, things broke because the new defaults
were not applied, so the new preferences were not in place,
and we had to have code checking for `undefined` everywhere
we wanted to use the newly added preference.

This change applies defaults to stored data where the properties
do not already exist, allowing us to apply defaults to
stored data that was produced before we added the new preferences.
    @notnownikki
    notnownikki committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    1a4e4e4 View commit details
    Browse the repository at this point in the history

  2. Object unrolling FTW

    @notnownikki
    notnownikki committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    cfd39d7 View commit details
    Browse the repository at this point in the history