Navigation Editor: Improve experience for user creating their first menu #28767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.38 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
talldan
force-pushed
the
fix/handle-no-menus
branch
from
5f60868
to
3253561
Compare
talldan
added
[Feature] Navigation Screen
[Type] Enhancement
talldan
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726 and
nerrad
as code owners
talldan
requested review from
noisysocks,
ntwb and
tellthemachines
as code owners
talldan
changed the title
kevin940726
reviewed
Feb 12, 2021
Co-authored-by: Kai Hao <kevin830726@gmail.com>
draganescu
approved these changes
Feb 15, 2021
talldan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #28124
The flow for users creating a first menu has been less than idea or even somewhat broken for a while. This updates the flow to follow the designs in #28124.
It doesn't update the navigation block placeholder as shown in those designs, but that can come in a later PR.
There are a few areas where our component system doesn't quite match the designs
We may want to update these component styles separately.
How has this been tested?
e2e tests updated for this feature.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: