docgen: don't transpile the package code #28910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
update/docgen-no-build
branch
from
4161f38
to
ae5c832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
docgenpackage is Node.js only and exports only a bin executable (not even a module API), and yet it's transpiled by Babel intobuildandbuild-modulefolders.This PR fixes that by renaming the
srcmodule tolibso that the build scripts don't pick the sources automatically when they search with asrc/**/*.jsglob. Thetestdirectory is no longer a subfolder oflib, but its sibling at the top level.The
package/envis a good prior art here: it uses thelibfolder already.How to test:
Run
npm run docs:buildand check that it succeeds. Also run thedocgenunit tests. There should be no observable changes in the package behavior at all.