New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel-plugin-makepot: don't transpile the package code #28911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Feb 10, 2021
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package lock file needs to be updated to reflect changes in packages, but otherwise all good 👍
jsnajdr
force-pushed
the
update/babel-plugin-makepot-nobuild
branch
from
February 11, 2021 11:28
a381fbc
to
e1855b3
Compare
Lockfile updated 🙂 As expected, it only removed one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #28910, but for the
babel-plugin-makepot
package. No Babel transpilation, themain
field points directly to theindex.js
file.The
babel-plugin-import-jsx-pragma
andbabel-preset-default
packages already use the same layout.