Make navigation editor end-to-end tests more robust #28936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Feb 11, 2021
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
* Wait for loading to finish in e2e test * Simplify and add some more assertions
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
* Wait for loading to finish in e2e test * Simplify and add some more assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28903
Both navigation editor tests have been failing intermittently.
I haven't completely worked out why! The most common failure was on this line:
Changing this to seems to fix things
I went from some failures to none locally. I had a quick look at puppeteer's code and it seems that using the
visibleorhiddenoptions switches the wait from using aMutationObservertorequestAnimationFramepolling. It might be that there's an underlying issue in puppeteer when waiting forinnerTextto change using aMutationObserver, but I couldn't see what.I added in a few other
waitForSelectorcalls to fix a second issue, where the snapshot is sometimes tested before before any blocks have been created.How has this been tested?
Ran the tests a bunch of times locally
Types of changes
Bug fix (non-breaking change which fixes an issue)