New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Inject theme attribute into template parts too #29080
Site Editor: Inject theme attribute into template parts too #29080
Conversation
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as advertised. The issue reported is fixed, and I wouldn't expect regressions here.
This said, I'd rather have another 👀 from @jeyip in the off-chance I'm missing some context regarding the reason for only injecting the theme attribute into templates.
Left a comment here #28814 (comment). It was an oversight 👍 Currently testing the fix in a few browsers. |
TestingBehavior
Browsers
|
Fixes #28814
Description
#28088 introduced a feature that injects the theme attribute into templates. Template parts are untouched, this caused nested template part files to fail. This PR enables the theme attribute injection for template parts as well.
How has this been tested?
test
template part file in your theme (TT1 blocks) with the content below:<!-- wp:template-part {"slug":"header"} /-->
test
test
template part should contain theheader
template partTypes of changes
Bug fix (non-breaking change which fixes an issue) ?
Checklist: