Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post & Site Editor: Not loading on IE11 #28249

Closed
jeyip opened this issue Jan 15, 2021 · 14 comments
Closed

Post & Site Editor: Not loading on IE11 #28249

jeyip opened this issue Jan 15, 2021 · 14 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended

Comments

@jeyip
Copy link
Contributor

jeyip commented Jan 15, 2021

Description

When visiting the site editor in IE11, the editor displays a wsod. I didn't see any console warnings.

Step-by-step reproduction instructions

  • Select a block theme that enables site editing
  • Visit site editor in IE11 browser

Screenshots or screen recording (optional)

Screen Shot 2021-02-05 at 11 45 43 AM

WordPress information

  • WordPress version: 5.7-alpha-49962
  • Gutenberg version: Dev version up to commit 6accb5b
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No (Using TT1-blocks)

Device information

  • Device: Macbook Pro
  • Operating system: macOS Big Sur 11.0.1
  • Browser: IE11
@jeyip jeyip added [Type] Bug An existing feature does not function as intended [Feature] Full Site Editing labels Jan 15, 2021
@jeyip
Copy link
Contributor Author

jeyip commented Jan 30, 2021

I just tested it again. It looks like IE11 is loading the full site editor properly again. Closing this ticket for now.

@jeyip
Copy link
Contributor Author

jeyip commented Feb 5, 2021

Reopened the ticket because the wsod is back 😞

@paaljoachim
Copy link
Contributor

Microsoft has ended all support of IE 11. Should we close this issue?

@aristath
Copy link
Member

IE11 usage dropped to < 1%, so I wouldn't be surprised if we stop supporting it pretty soon. That was the threshold we always had for browser supports...
FSE also relies heavily on CSS-Variables and other features that IE11 doesn't support so it's safe to assume that IE is not on the top of anyone's priorities list.

@diegohaz
Copy link
Member

I see these errors on the console:

SCRIPT5009: 'Proxy' is undefined
index.js (27557,5)
SCRIPT5007: Unable to get property 'withFilters' of undefined or null reference
index.js (9650,30)
SCRIPT5007: Unable to get property 'withFocusReturn' of undefined or null reference
index.js (3990,30)
SCRIPT5007: Unable to get property 'withNotices' of undefined or null reference
index.js (17200,30)
SCRIPT5007: Unable to get property 'createSlotFill' of undefined or null reference
index.js (2962,1)
SCRIPT5007: Unable to get property 'withSpokenMessages' of undefined or null reference
index.js (1207,30)
SCRIPT5007: Unable to get property 'initializeEditor' of undefined or null reference
post-new.php (2508,4)
SCRIPT7002: XMLHttpRequest: Network Error 0x2ee7, Could not complete the operation due to error 00002ee7.
post-new.php

Looks like the first one (SCRIPT5009: 'Proxy' is undefined) is related to the Framer Motion dependency. Not sure if it supports IE11.

@paaljoachim
Copy link
Contributor

It looks like we are getting very near to just closing this issue. As a wont fix.
Let me know and I will close it.

@jeyip
Copy link
Contributor Author

jeyip commented Feb 25, 2021

This definitely isn't the highest on the priority list for the full site editing project, but IE11 is still technically listed as a browser supported by both Gutenberg and WordPress. I also think there's value in keeping this open so others don't post duplicate issues.

With all that being said, if I'm not mistaken, there's already discussion about dropping support for IE11 in the broader WordPress community. I'd personally prefer to close this when dropping support is finalized, but if others feel strongly about closing it now, it's not something I'll firmly oppose.

@annezazu
Copy link
Contributor

Just chiming in here to say that, after this last week's core editor meeting, a group of us are working on a post to propose dropping IE11 support. I'd hold off until that discussion has been had and a decision is reached in time by project leadership.

@ryelle
Copy link
Contributor

ryelle commented Mar 1, 2021

It looks like this affects all editors - the post editor is also white-screening for me on WP trunk, with the same errors from #28249 (comment)

@youknowriad youknowriad added the [Priority] High Used to indicate top priority items that need quick attention label Mar 1, 2021
@youknowriad
Copy link
Contributor

I agree here, if this is affecting the post editor we need to fix this for WP 5.7 (which is very soon 😬 )

@youknowriad youknowriad added Browser Issues Issues or PRs that are related to browser specific problems and removed [Feature] Full Site Editing labels Mar 1, 2021
@noisysocks
Copy link
Member

noisysocks commented Mar 2, 2021

I dug into this a little bit. The error comes from framer-motion using Proxy which is an ES6 API that we do not polyfill. framer-motion is included by @wp-g2 which we use in a few @wordpress/components.

We do not use @wp-g2 in Core, however, which sets process.env.COMPONENT_SYSTEM_PHASE to 0. In Core, this dependency tree is omitted from the generated bundle so long as 'mode' in webpack is set to 'production'.

I confirmed this locally by navigating to Posts → Add New in an IE 11 virtual machine.

  • Running 5.7 branch with no Gutenberg, assets built using grunt build: No error
  • Running 5.7 branch with no Gutenberg, assets built using grunt build --dev: Error
  • Running 5.6 branch with Gutenberg trunk, assets built using grunt build and npm run build: Error
  • Running 5.6 branch with Gutenberg trunk, assets built using grunt build and npm run dev: Error

Users using WordPress 5.7 without the Gutenberg plugin activated will still be able to create and edit posts in IE 11. I'm therefore removing this issue from the Must Haves board.

Users using any version of WordPress with the Gutenberg plugin activated are not able to create and edit posts in IE 11. I'm therefore leaving the issue open.

@noisysocks noisysocks removed the [Priority] High Used to indicate top priority items that need quick attention label Mar 2, 2021
@gziolo
Copy link
Member

gziolo commented Mar 2, 2021

@ItsJonQ and @sarayourfriend, can you investigate what's required to convenience IE11 to work with G2 components?

@ItsJonQ
Copy link

ItsJonQ commented Mar 2, 2021

@gziolo Will do! Thank you all for the notes!

@priethor priethor changed the title Side Editor: Not loading on IE11 Post & Site Editor: Not loading on IE11 Mar 9, 2021
@youknowriad
Copy link
Contributor

IE11 support is being dropped, context:

I'm closing this issue as it's not something we'll be investing in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

10 participants