Fix php error in the widget screen #29137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
kevin940726
added this to PRs needing review
in Block-based Widgets Editor
via automation
|
Size Change: +323 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Edit, wrong issue. |
draganescu
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug introduced in #26375. Probably a rebase error?
Not sure if the fix makes sense though, could need some reviews from some PHP developers.
How has this been tested?
Manually, there should be no more PHP errors in the widgets screen.
Types of changes
Bug fix
Checklist: