New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buttons: Add space-between justification controls #29160
Conversation
Size Change: +65 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Thanks for this! I'm not seeing it have any effect, though, on the horizontal one (and I agree it shouldn't be there for the vertical one): Buttons had "fake" space between recently, because the horizontal margins were set to auto (see also #28878) — but in inspecting, I don't see any justification CSS being output. It works when I add |
Also, good to be aware of: #29165 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a partial revert of #29160, but this can be re-enabled after testing, when support for this is added on mobile.
Description
In #28768 the justificatoon toolbar was added, however the space-between option was purposely left out to match previous functionality. Well, turns out there was no real reason and buttons get space-between too.
How has this been tested?
Screenshots
Types of changes
Open Question
@jasmussen what should we do about
is-vertical
? This might be why it was left off previously.After recording the screenshot, it seems rather obvious that it doesn't quite make sense for vertical, so I pushed up a change to remove the option if vertical orientation. So if/when you test that will be different than screenshot.