Fix server rendered widget not previewing #29197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
added this to PRs needing review
in Block-based Widgets Editor
via automation
|
Size Change: +985 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
Feb 23, 2021
| @@ -60,12 +61,16 @@ export class ServerSideRender extends Component { | |||
| urlQueryArgs = {}, | |||
| } = props; | |||
|
|
|||
| const sanitizedAttributes = | |||
| attributes && | |||
| __experimentalSanitizeBlockAttributes( block, attributes ); | |||
There was a problem hiding this comment.
Just thinking out loud: An alternative could be to use createBlock here. That way we wouldn't need to add any extra public functions to @wordpress/blocks.
const sanitizedAttributes = createBlock( block, attributes ).attributes;But I suppose it makes sense for @wordpress/blocks to have sanitizeBlockAttributes as it might be useful in other situations? What do you think?
There was a problem hiding this comment.
Clever! But I fear that it's semantically incorrect? In the future, we could add more logics to the createBlock factory than sanitizeBlockAttributes only, that would be hard to catch any unexpected side-effects here.
7 tasks
7 tasks
3 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally raised in #29111 (comment).
The problem is that the endpoint
<ServerSideRender>is using will try to validate theattributes. Since we're passing__internalWidgetIdnow (#29111) to every blocks in the widgets screen, this breaks on the server side.The solution is to sanitize the attributes before sending them to the server. It should be backward-compatible if the client and the server are using the same logic to sanitize/validate the attributes. This PR leverages the
sanitizeBlockAttributesAPI to achieve this, not sure if we should mark it as experimental at this stage though.How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: