Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update navigation editor menu selection dropdown #29202

Merged
merged 18 commits into from Mar 8, 2021
Merged

Update navigation editor menu selection dropdown #29202

merged 18 commits into from Mar 8, 2021

Commits on Mar 8, 2021

  1. Initial wrangling of add menu form into modal

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    ff3de98 View commit details
    Browse the repository at this point in the history

  2. Rename dropdown toggle

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    491684c View commit details
    Browse the repository at this point in the history

  3. Fix focus return

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    cfbbffc View commit details
    Browse the repository at this point in the history

  4. Close modal on menu creation

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4270f99 View commit details
    Browse the repository at this point in the history

  5. Make separator-less menu groups possible

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6f94eda View commit details
    Browse the repository at this point in the history

  6. Rename menu option

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    1a2ce57 View commit details
    Browse the repository at this point in the history

  7. Style primary menu item

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3e18bc7 View commit details
    Browse the repository at this point in the history

  8. Improve string handling in AddMenu component

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    ae79cd2 View commit details
    Browse the repository at this point in the history

  9. Close dropdown on menu creation

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d11931a View commit details
    Browse the repository at this point in the history

  10. Dismiss menu creation notices on re-attempt

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4ed27fa View commit details
    Browse the repository at this point in the history

  11. Use focus on mount hook

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    24499b5 View commit details
    Browse the repository at this point in the history

  12. Add some extra hints for screenreader users

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    bff9991 View commit details
    Browse the repository at this point in the history

  13. Use destructuring

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    07708ad View commit details
    Browse the repository at this point in the history

  14. Refactor menu items into MenuSwitcher component

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    954c3c7 View commit details
    Browse the repository at this point in the history

  15. Use z-index file for z-index

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    933cbab View commit details
    Browse the repository at this point in the history

  16. Add e2e test

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    391d5a4 View commit details
    Browse the repository at this point in the history

  17. Remove wrapping function

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    2d69dd9 View commit details
    Browse the repository at this point in the history

  18. Use separate functions for opening and closing modal

    @talldan
    talldan committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8fecef7 View commit details
    Browse the repository at this point in the history