Update navigation editor menu selection dropdown #29202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
|
Size Change: +505 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Merged
7 tasks
grzim
reviewed
Feb 25, 2021
grzim
reviewed
Feb 25, 2021
grzim
reviewed
Feb 25, 2021
talldan
force-pushed
the
update/nav-editor-menu-selection
branch
2 times, most recently
from
cc9602a
to
e510dd2
Compare
talldan
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
kevin940726,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
|
I tested this and the only nitpick is that the input in the new menu modal does not get autofocus. Can that / should that be handled in this PR @talldan ? |
|
@draganescu Yeah, I did try this, but it breaks the way focus is supposed to return when closing a modal (e.g. pressing escape). So a focus loss will happen when autofocusing. The new I can create a separate issue for it. |
talldan
force-pushed
the
update/nav-editor-menu-selection
branch
from
e510dd2
to
2d69dd9
Compare
grzim
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #28863
Makes some changes to menu creation:
How has this been tested?
Added an e2e test
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: