Buttons: Fix links inside links #29273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or tags before saving.
apeatling
added
[Type] Bug
|
Size Change: +44 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Feb 24, 2021
|
@aristath Does this one look okay to merge? |
|
Should we intercept pasting a link and apply it to the URL field instead? |
|
That could be a good improvement, yes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24722
Description
When a link is pasted inside of a button block or a file download block button, the block becomes invalid and does not render correctly in the front end. See #24722. This PR strips anchors from text content in these buttons so that they cannot be added within another anchor.
How has this been tested?
Tested locally.
Checklist: