File block: Remove anchor tag when copy pasting to file name #56508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +345 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
commented
Nov 24, 2023
Comment on lines
106
to
108
| downloadButtonText: removeAnchorTag( | ||
| _x( 'Download', 'button label' ) | ||
| ), |
There was a problem hiding this comment.
Although this would not be necessary in practice, it allows for the possibility that the translated text has anchors.
There was a problem hiding this comment.
This translated text shouldn't have HTML in it, and React shouldn't render it anyway. So I agree this is unnecessary.
We can't strip every possible translation.
There was a problem hiding this comment.
Indeed. Updated with 0bf95cd 👍
|
Flaky tests detected in 0bf95cd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6982994376
|
aaronrobertshaw
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Nice fix @t-hamano 👍
✅ Everything tests as advertised
✅ Anchor tags are correctly stripped out
✅ Block isn't broken and renders as expected on the frontend
Do you think it is worth extracting the removeAnchorTag into a helper function that can be shared across blocks?
LGTM 🚢
|
Thanks for the review, @aaronrobertshaw!
That makes sense. Updated 👍 |
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* File block: Remove anchor tag when copy pasting to file name * Don't strip default button text * eEtract removeAnchorTag() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54820
Follow-up #29273
What?
This PR fixes an issue where if content containing an anchor is pasted into the filename of a file block, validation will fail and the block will become corrupted.
Why?
This block's file name and button are both anchor elements, so you cannot put an anchor element inside them. In #29273, this issue was fixed for the download button, but the same fix should be applied for the file name as well.
How?
I also added a process to remove anchors in the file name. At the same time, I changed the function name to something easier to understand, and changed the function to purely processing strings without executing
setAttributes()inside the function.Testing Instructions
Screenshots or screencast
132a90c04813d9e5778b77e5a201d2a7.mp4