-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Fix the template area unassigned type string #29617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Full Site Editing
[Type] Experimental
Experimental feature or API.
labels
Mar 8, 2021
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
March 8, 2021 09:51
youknowriad
added
the
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
label
Mar 8, 2021
youknowriad
force-pushed
the
fix/i18n-template-area-string
branch
from
March 8, 2021 09:53
598a761
to
2fc21a5
Compare
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
aristath
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29586
Just a small PR to make the string more translatable. We shouldn't concat any translatable strings.