[RNMobile] Accessibility updates for StepperCell and RangeCell #29741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes make this component easier to work with in VoiceOver by using standard accessibility actions for changing the values of this component.
|
Size Change: +2.63 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
AmandaRiu
commented
Mar 11, 2021
AmandaRiu
commented
Mar 11, 2021
…ct other components using this class.
…and `RangeCell` components as self-contained units. With this change TalkBack will no longer focus on the child elements of these components during navigation.
This property controls what the screenreader announces as the “type” of the value. Default is “value” if none is provided.
AmandaRiu
added
[Focus] Accessibility (a11y)
Merged
2 tasks
AmandaRiu
force-pushed
the
rnmobile/29359-ios-bottome-cell-accessibility
branch
from
da93236
to
ca49b6b
Compare
AmandaRiu
force-pushed
the
rnmobile/29359-ios-bottome-cell-accessibility
branch
from
ca49b6b
to
7046b53
Compare
dcalhoun
reviewed
Mar 17, 2021
packages/components/src/mobile/bottom-sheet/range-cell.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/bottom-sheet/range-cell.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/bottom-sheet/range-cell.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/bottom-sheet/stepper-cell/index.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/bottom-sheet/stepper-cell/index.native.js
Outdated
Show resolved
Hide resolved
|
@dcalhoun I've addressed all the code comments. Ready for another round! 👍 |
dcalhoun
approved these changes
Mar 18, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR
wordpress-mobile/gutenberg-mobile#3255
Description
Fixes #29359 by changing the way VoiceOver interacts with the
RangeCellandStepperCellcomponents.This PR fixes #29359 and contains code changes to both
StepperCellandRangeCellto force theUnitControlcomponent to behave uniformly with iOS VoiceOver and Android TalkBack.Improvements include:
StepperCellandRangeCellcomponents.Width is 60 pixelsinstead ofValue is 60. This is done with a new optionalsettingLabelproperty onUnitControl. If none is provided it will default toValueto keep backwards compatibility.UnitControlcomponent now utilizes standardAccessibilityActionsfor interacting with the component:increment,decrement, andactivate. Theactivateoption opens the unit picker (an option that wasn’t previously available on iOS for theStepperCell.Not included are the following future enhancement
Known Issues
When changing the number of columns setting in the Columns block on iOS with VoiceOver, you'll notice that the gesture to move to the next setting will not work. This is not related to the changes in this PR as it was happening before this change. I believe this is happening because an additional Column setting is added to the bottom sheet and then quickly removed once the number of columns is decremented again and so iOS is trying to move to a setting that isn't technically there anymore.
How has this been tested?
Tested on iOS with VoiceOver and Android with TalkBack:
iOS
Android
Screenshots
iOS VoiceOver Before
ios-voiceover-before.mp4
iOS VoiceOver After
ios-voiceover-after.mp4
Android TalkBack Before
Note: in order to get the audio for Android I had to test on an emulator which means I had to use swipe up and down gestures instead of the volume keys for these videos. The experience is much nicer on a physical device using the volume keys.
android-talkback-before.mp4
Android TalkBack After
android-talkback-after.mp4
Types of changes
Improvements to the way TalkBack and VoiceOver interact with the
UnitControlbottom sheet setting component.Checklist: