Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.50.0 #3324

Merged
merged 159 commits into from
Apr 1, 2021
Merged

Release 1.50.0 #3324

merged 159 commits into from
Apr 1, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Mar 31, 2021

Release for Gutenberg Mobile 1.50.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

@jd-alexander
Copy link
Contributor

jd-alexander commented Mar 31, 2021

For the task ci/circleci: Build Android RN Bridge & Publish to Bintray the output is
Build initiated from a feature branch with no pull request: aborting. I am thinking this means this needs to be re-run?

Re-running since this PR exists.

@jd-alexander jd-alexander marked this pull request as ready for review March 31, 2021 17:52
@jd-alexander jd-alexander marked this pull request as draft March 31, 2021 17:54
@guarani guarani added this to the 1.50.0 (17.1) milestone Mar 31, 2021
@guarani guarani marked this pull request as ready for review March 31, 2021 21:28
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested the demo app, WPAndroid, and WPiOS and didn't see any issues.

I looked into the merge conflict a little, and it looks like that is occurring because the PR merging trunk into develop for 1.49.0 squashed the commits after resolving the conflicts, so now the conflicts are reappearing since GitHub doesn't realize they were already resolved. In other words, the presence of conflicts in this PR doesn't seem to indicate that anything is wrong.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. LGTM 🚢

@jd-alexander jd-alexander merged commit f7a404d into trunk Apr 1, 2021
@jd-alexander jd-alexander deleted the release/1.50.0 branch April 1, 2021 22:14
@jd-alexander jd-alexander mentioned this pull request Apr 2, 2021
2 tasks
@geriux
Copy link
Member

geriux commented Apr 7, 2021

Android (Test Suite 2) 🟡

DarkMode - 1

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007
  • ⚠️ The Space between alignment shows in the toolbar but currently doesn't work because there's no support for it, items remain aligned to the left (issue) I don't think it's a blocker for the release.

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • ❌ Scroll color palette to start - TC002
  • ⚠️ It doesn't auto-scroll to the beginning (issue)
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • ❌ Story block - Add media to non-empty Story block - TC004
  • ⚠️ I encountered some issues but not sure if its related to my device or not see video below (issue TBD)
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

❌ Story block - Add media to non-empty Story block

When trying to edit an non-empty story block I found some issues:

  • When opening its all black, you have to select the second story for the content to show up, once you do that you can select the first one and see it too.
  • The text added to the first story get removed
Screenrecorder-2021-04-07-14-34-19-438.mp4

@jd-alexander
Copy link
Contributor

Writing Flow - Android

I tested the writing Flow cases on version 17.1-rc-1 of the WordPress Android release.


Writing Flow checklist

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@guarani
Copy link
Contributor Author

guarani commented Apr 7, 2021

Writing Flow - iOS

Testing Writing Flow cases on 17.1 (17.1.0.0) beta from Test Flight:


Writing Flow checklist

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux
Copy link
Member

geriux commented Apr 7, 2021

Hey @mzorz 👋 while doing some sanity tests for the Story block on Android I encountered an issue and I was wondering if this is known, if it's something new or just specific to the device I used.

Can you please take a look at the issue I described here #3324 (comment) I added a video at the end of the comment. Thanks!

@geriux
Copy link
Member

geriux commented Apr 8, 2021

Update:

❌ Story block - Add media to non-empty Story block

When opening its all black, you have to select the second story for the content to show up, once you do that you can select the first one and see it too.

This one is being investigated.

The text added to the first story get removed

There's an open issue for this one already.

Buttons block - Buttons alignment options - TC007

⚠️ The Space between alignment shows in the toolbar but currently doesn't work because there's no support for it, items remain aligned to the left (issue) I don't think it's a blocker for the release.

A PR was opened to disable this new alignment but this won't be a blocker since it's not a new regression for this release.

@geriux
Copy link
Member

geriux commented Apr 9, 2021

Update:

❌ Story block - Add media to non-empty Story block

It is not a blocker for the Gutenberg mobile release, an issue was opened to fix it that and will be included either in WordPress-Android or stories-android.

With that, there aren't any blockers from Android (Test Suite 2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet