Widgets Customizer: Add Legacy Widget block #30321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires up the Legacy Widget block to the Widgets Customizer.
Removes __unstable_instance from the instance object returned by the Customizer and instead add raw_instance. This property is only added if the widget has declared that it supports raw instances via the show_instance_in_rest flag.
noisysocks
added
[Type] Experimental
noisysocks
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
noisysocks
added this to PRs needing review
in Block-based Widgets Editor
via automation
noisysocks
changed the title
|
Hm, adding a new Legacy Widget block should work now that #30221 is merged but doesn't. Investigating. |
kevin940726
reviewed
Mar 29, 2021
There was a problem hiding this comment.
It works great!
When I'm trying to preview the legacy widgets, they throw this error in the iframe though.
Notice: Constant IFRAME_REQUEST already defined in /var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/legacy-widget.php on line 74
Not sure if it's related to this PR.
|
I think it's the final missing piece of #29284? |
grzim
reviewed
Mar 30, 2021
packages/customize-widgets/src/components/sidebar-block-editor/use-sidebar-block-editor.js
Show resolved
Hide resolved
|
Size Change: +456 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #30265.
Closes #30266.
Wires up the Legacy Widget block — which was rewritten in #29960 — to the Widgets Customizer and removes the
__unstable_instancehack added in #29365 in favour of a correct and more permanent solution.How has this been tested?
Screenshots
Kapture.2021-03-29.at.16.04.41.mp4
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).