Polish navigation menu submenus. #30335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
adamziel,
kevin940726,
noisysocks and
tellthemachines
as code owners
|
Size Change: +290 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 29, 2021
|
This looks great, thanks for taking it on! |
|
My pleasure! Thank you for fast reviews 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR polishes the navigation screen, specifically on the topic of submenus.
It:
GIF:
[1] — I know that there has been discussions that the Page List should never be present in a custom menu created like this. That can still be the case, but in case you manage to somehow sneak one in there, at least now it's padding, spacing, and appearance and behavior makes sense. That is, it's shown gray and is inert, with submenus not triggering.
Note: The black chevron on the Page List will be fixed by #30287.
How has this been tested?
Please test the navigation screen with submenus. Also test with a page list if you like!
Checklist:
*.native.jsfiles for terms that need renaming or removal).